Discussion:
factory: armv7l: fix kernel build
(too old to reply)
m***@public.gmane.org
2014-06-11 08:37:00 UTC
Permalink
Raw Message
From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001
From: "Matwey V. Kornilov" <matwey.kornilov-***@public.gmane.org>
Date: Mon, 2 Jun 2014 20:17:29 +0400
Subject: [PATCH] Replace type of paddr to uint32_t.

This patch helps to avoid the following build issue:

drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror]
msm_gem_get_iova_locked(fbdev->bo, 0, &paddr);
^
In file included from drivers/gpu/drm/msm/msm_fbdev.c:18:0:
drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but argument is of type 'dma_addr_t *'
int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id,
^

Signed-off-by: Matwey V. Kornilov <matwey-***@public.gmane.org>
Patch-mainline: Submitted, 1401879270 - linux-arm-msm-***@public.gmane.org
Signed-off-by: Matwey V. Kornilov <matwey.kornilov-***@public.gmane.org>

---
This is for Factory, 3.15 is still failed for armv7l.

drivers/gpu/drm/msm/msm_fbdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index a752ab8..5107fc4 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -59,7 +59,7 @@ static int msm_fbdev_create(struct drm_fb_helper *helper,
struct drm_framebuffer *fb = NULL;
struct fb_info *fbi = NULL;
struct drm_mode_fb_cmd2 mode_cmd = {0};
- dma_addr_t paddr;
+ uint32_t paddr;
int ret, size;

sizes->surface_bpp = 32;
--
1.9.3
Andreas Färber
2014-06-21 15:31:46 UTC
Permalink
Raw Message
From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001
Date: Mon, 2 Jun 2014 20:17:29 +0400
Subject: [PATCH] Replace type of paddr to uint32_t.
drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror]
msm_gem_get_iova_locked(fbdev->bo, 0, &paddr);
^
drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but argument is of type 'dma_addr_t *'
int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id,
^
---
This is for Factory, 3.15 is still failed for armv7l.
Ping! Patch is queued on msm-fixes-3.16 (with modified subject,
additional Sob):

http://cgit.freedesktop.org/~robclark/linux/commit/?h=msm-fixes-3.16&id=70bdd6c7c8e4d36b336f0b6f8b653aa9db3a6f33

Can we please get this applied as build fix for kernel-default and
kernel-lpae?

Thanks,
Andreas
drivers/gpu/drm/msm/msm_fbdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index a752ab8..5107fc4 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -59,7 +59,7 @@ static int msm_fbdev_create(struct drm_fb_helper *helper,
struct drm_framebuffer *fb = NULL;
struct fb_info *fbi = NULL;
struct drm_mode_fb_cmd2 mode_cmd = {0};
- dma_addr_t paddr;
+ uint32_t paddr;
int ret, size;
sizes->surface_bpp = 32;
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe, e-mail: opensuse-kernel+unsubscribe-***@public.gmane.org
To contact the owner, e-mail: opensuse-kernel+owner-***@public.gmane.org
Jean Delvare
2014-06-23 13:21:34 UTC
Permalink
Raw Message
Hi Andreas, Matwey,
Post by Andreas Färber
From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001
Date: Mon, 2 Jun 2014 20:17:29 +0400
Subject: [PATCH] Replace type of paddr to uint32_t.
drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror]
msm_gem_get_iova_locked(fbdev->bo, 0, &paddr);
^
drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but argument is of type 'dma_addr_t *'
int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id,
^
---
This is for Factory, 3.15 is still failed for armv7l.
Ping! Patch is queued on msm-fixes-3.16 (with modified subject,
http://cgit.freedesktop.org/~robclark/linux/commit/?h=msm-fixes-3.16&id=70bdd6c7c8e4d36b336f0b6f8b653aa9db3a6f33
Can we please get this applied as build fix for kernel-default and
kernel-lpae?
The upstream discussion game me the impression that this patch would not
make it upstream:
http://www.spinics.net/lists/linux-arm-msm/msg09616.html
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe, e-mail: opensuse-kernel+unsubscribe-***@public.gmane.org
To contact the owner, e-mail: opensuse-kernel+owner-***@public.gmane.org
Andreas Färber
2014-06-23 13:41:01 UTC
Permalink
Raw Message
Post by Jean Delvare
Hi Andreas, Matwey,
Post by Andreas Färber
From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001
Date: Mon, 2 Jun 2014 20:17:29 +0400
Subject: [PATCH] Replace type of paddr to uint32_t.
drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror]
msm_gem_get_iova_locked(fbdev->bo, 0, &paddr);
^
drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but argument is of type 'dma_addr_t *'
int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id,
^
---
This is for Factory, 3.15 is still failed for armv7l.
Ping! Patch is queued on msm-fixes-3.16 (with modified subject,
http://cgit.freedesktop.org/~robclark/linux/commit/?h=msm-fixes-3.16&id=70bdd6c7c8e4d36b336f0b6f8b653aa9db3a6f33
Can we please get this applied as build fix for kernel-default and
kernel-lpae?
The upstream discussion game me the impression that this patch would not
http://www.spinics.net/lists/linux-arm-msm/msg09616.html
Rob rejected that suggestion (and confirmed on IRC):
http://www.spinics.net/lists/linux-arm-msm/msg09621.html

His pull was supposed to go out this weekend but missed -rc2 apparently.

Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe, e-mail: opensuse-kernel+unsubscribe-***@public.gmane.org
To contact the owner, e-mail: opensuse-kernel+owner-***@public.gmane.org
Jean Delvare
2014-07-01 08:23:58 UTC
Permalink
Raw Message
Hi Andreas,
Post by Andreas Färber
Post by Jean Delvare
Post by Andreas Färber
Ping! Patch is queued on msm-fixes-3.16 (with modified subject,
http://cgit.freedesktop.org/~robclark/linux/commit/?h=msm-fixes-3.16&id=70bdd6c7c8e4d36b336f0b6f8b653aa9db3a6f33
Can we please get this applied as build fix for kernel-default and
kernel-lpae?
The upstream discussion game me the impression that this patch would not
http://www.spinics.net/lists/linux-arm-msm/msg09616.html
http://www.spinics.net/lists/linux-arm-msm/msg09621.html
His pull was supposed to go out this weekend but missed -rc2 apparently.
Sorry for the late reply, I have just pushed the fix to the master
branch.

I think it is needed on the stable branch too (i.e. kernel 3.15 is
affected too), right?
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe, e-mail: opensuse-kernel+unsubscribe-***@public.gmane.org
To contact the owner, e-mail: opensuse-kernel+owner-***@public.gmane.org
Matwey V. Kornilov
2014-07-01 08:28:48 UTC
Permalink
Raw Message
Post by Jean Delvare
Sorry for the late reply, I have just pushed the fix to the master
branch.
I think it is needed on the stable branch too (i.e. kernel 3.15 is
affected too), right?
Yes, it is.

p.s. ARM has been dissapeared from Kernel:HEAD. Why?
--
With best regards,
Matwey V. Kornilov
http://blog.matwey.name
xmpp:0x2207-962d5TIgE1qHXe+***@public.gmane.org
Jean Delvare
2014-07-01 08:44:53 UTC
Permalink
Raw Message
Post by Matwey V. Kornilov
Post by Jean Delvare
Sorry for the late reply, I have just pushed the fix to the master
branch.
I think it is needed on the stable branch too (i.e. kernel 3.15 is
affected too), right?
Yes, it is.
OK, fix pushed to the stable kernel branch too.
Post by Matwey V. Kornilov
p.s. ARM has been dissapeared from Kernel:HEAD. Why?
No idea, I'm not responsible for that, sorry.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe, e-mail: opensuse-kernel+unsubscribe-***@public.gmane.org
To contact the owner, e-mail: opensuse-kernel+owner-***@public.gmane.org
Guillaume Gardet
2014-07-01 08:47:47 UTC
Permalink
Raw Message
Hi,
Post by Jean Delvare
Post by Matwey V. Kornilov
Post by Jean Delvare
Sorry for the late reply, I have just pushed the fix to the master
branch.
I think it is needed on the stable branch too (i.e. kernel 3.15 is
affected too), right?
Yes, it is.
OK, fix pushed to the stable kernel branch too.
Post by Matwey V. Kornilov
p.s. ARM has been dissapeared from Kernel:HEAD. Why?
No idea, I'm not responsible for that, sorry.
At each kernel version upgrade, ARM is disabled until "ARM people" take care of new options and re-enable ARM configs.
See: http://kernel.opensuse.org/cgit/kernel-source/commit/?id=6ff907a8876f8dbf06da4c53fd8380e237a9442f


Guillaume
--
To unsubscribe, e-mail: opensuse-kernel+unsubscribe-***@public.gmane.org
To contact the owner, e-mail: opensuse-kernel+owner-***@public.gmane.org
Matwey V. Kornilov
2014-07-01 08:49:20 UTC
Permalink
Raw Message
Post by Guillaume Gardet
At each kernel version upgrade, ARM is disabled until "ARM people" take care of new options and re-enable ARM configs.
See: http://kernel.opensuse.org/cgit/kernel-source/commit/?id=6ff907a8876f8dbf06da4c53fd8380e237a9442f
Now I see, thank you.
--
With best regards,
Matwey V. Kornilov
http://blog.matwey.name
xmpp:0x2207-962d5TIgE1qHXe+***@public.gmane.org
Andreas Färber
2014-07-01 13:48:16 UTC
Permalink
Raw Message
Post by Guillaume Gardet
Post by Jean Delvare
Post by Matwey V. Kornilov
Post by Jean Delvare
Sorry for the late reply, I have just pushed the fix to the master
branch.
I think it is needed on the stable branch too (i.e. kernel 3.15 is
affected too), right?
Yes, it is.
OK, fix pushed to the stable kernel branch too.
Post by Matwey V. Kornilov
p.s. ARM has been dissapeared from Kernel:HEAD. Why?
No idea, I'm not responsible for that, sorry.
At each kernel version upgrade, ARM is disabled until "ARM people" take care of new options and re-enable ARM configs.
See: http://kernel.opensuse.org/cgit/kernel-source/commit/?id=6ff907a8876f8dbf06da4c53fd8380e237a9442f
...which needs to wait on Xen patches to be applied first, as the SUSE
config options are not available in upstream; then after getting ARM
config updates applied, it takes days to get kernel build results, then
the reported errors are not fixed until we get the next major kernel
release update, yay. Not a single 3.15 ARM kernel got built. :-(

Guillaume, quick reminder in case you'll be quicker than me: We need to
remember to re-enable previously disabled Exynos/Samsung driver options
in default and lpae for 3.16. Some machines like S5PV210 are not yet
multi-platform, so I suggest we leave a stripped-down kernel-exynos
flavor until it's completely gone. Not sure how to migrate users over to
kernel-default then though, beyond editing our JeOS package list for new
images.

Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe, e-mail: opensuse-kernel+unsubscribe-***@public.gmane.org
To contact the owner, e-mail: opensuse-kernel+owner-***@public.gmane.org
Matwey V. Kornilov
2014-07-01 15:12:22 UTC
Permalink
Raw Message
Post by Andreas Färber
Not a single 3.15 ARM kernel got built. :-(
And existing 3.14 is broken. openSUSE is ready for arm! =)
Post by Andreas Färber
Guillaume, quick reminder in case you'll be quicker than me: We need to
remember to re-enable previously disabled Exynos/Samsung driver options
in default and lpae for 3.16.
Please, also disable omap4 video, it was discussed that it can work as
module.

Loading...