Discussion:
[PATCH] rpm/kernel-binary.spec.in: Fix missing quotes around %build_flavor
(too old to reply)
Andreas Schwab
2014-08-18 13:12:21 UTC
Permalink
Raw Message
%build_flavor can be an arbitrary string, so it needs to be quoted for
string comparison.
---
rpm/kernel-binary.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/rpm/kernel-binary.spec.in b/rpm/kernel-binary.spec.in
index 9db7c12..e319036 100644
--- a/rpm/kernel-binary.spec.in
+++ b/rpm/kernel-binary.spec.in
@@ -27,9 +27,9 @@
%include %_sourcedir/kernel-spec-macros

%define build_flavor @FLAVOR@
-%define build_default (%build_flavor == "default")
-%define build_xen (%build_flavor == "xen" || %build_flavor == "ec2")
-%define build_vanilla (%build_flavor == "vanilla")
+%define build_default ("%build_flavor" == "default")
+%define build_xen ("%build_flavor" == "xen" || "%build_flavor" == "ec2")
+%define build_vanilla ("%build_flavor" == "vanilla")

%define build_src_dir %my_builddir/linux-%srcversion
%define src_install_dir /usr/src/linux-%kernelrelease%variant
--
2.1.0
--
Andreas Schwab, SUSE Labs, schwab-***@public.gmane.org
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
Michal Marek
2014-08-18 13:45:15 UTC
Permalink
Raw Message
Post by Andreas Schwab
%build_flavor can be an arbitrary string, so it needs to be quoted for
string comparison.
---
rpm/kernel-binary.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.

Michal

Loading...